Closed
Conversation
* deps: alloy 0.12.5 * fix reth dep * lint
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Collaborator
|
Wen merge? :) |
dmarzzz
reviewed
Apr 15, 2025
| /// The transactions of the block. | ||
| pub transactions: Vec<Bytes>, | ||
| /// Array of [`Withdrawal`] enabled with V2 | ||
| pub withdrawals: Vec<Withdrawal>, |
Member
There was a problem hiding this comment.
the withdrawals should be immutable too no?
- Added gas_delta and tx_count_delta to payload metrics in get_payload_v3 and get_payload_v4. - Updated MetricsSpanProcessor to include INVALID_PAYLOAD tracking. - Refactored error handling in RpcClient to log invalid payloads instead of incrementing counters directly.
metrics updates
avalonche
reviewed
Apr 29, 2025
| } | ||
|
|
||
| #[derive(Parser, Debug)] | ||
| pub struct FlashblocksArgs { |
Collaborator
There was a problem hiding this comment.
could you add docs to README and .env.example
avalonche
reviewed
Apr 29, 2025
| let receiver = FlashblocksReceiverService::new(builder_url, tx)?; | ||
|
|
||
| tokio::spawn(async move { | ||
| let _ = receiver.run().await; |
Collaborator
There was a problem hiding this comment.
is there a need for error handling here?
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.